COMP: Update Main.cxx to explicitly include configure headers for used macros #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d macros This fixes a regression introduced in 451194ac6 (COMP: Remove obsolete version header includes) and apply a fix similar to 8c2143ee9 (COMP: Explicitly include version header where associated macros are used) See https://discourse.slicer.org/t/custom-app-compile-error-slicer-main-project-version-full-undefined/30577 Co-authored-by: Csaba Pinter <pinter.csaba@gmail.com> Co-authored-by: Kambiz Darabi <darabi@m-creations.com>
dzenanz
approved these changes
Jul 13, 2023
darabi
reviewed
Jul 13, 2023
| @@ -22,6 +22,8 @@ | |||
| // Slicer includes | |||
| #include "qSlicerApplication.h" | |||
| #include "qSlicerApplicationHelper.h" | |||
| #include "vtkSlicerConfigure.h" // For Slicer_MAIN_PROJECT_APPLICATION_NAME | |||
There was a problem hiding this comment.
Not strictly necessary, as it is included transitively via
qSlicerApplication.h -> qSlicerCoreApplication.h -> vtkSlicerConfigure.h
There was a problem hiding this comment.
Thanks for the review 🙏
While it is not strictly required, it is good practice to include headers for classes or macros directly used. It prevents issues if any of the files indirectly included are updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 451194ac6 (COMP: Remove obsolete version header includes) and apply a fix similar to 8c2143ee9 (COMP: Explicitly include version header where associated macros are used)
See https://discourse.slicer.org/t/custom-app-compile-error-slicer-main-project-version-full-undefined/30577